Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/stack-monitoring (#202860) #205139

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

pgayvallet
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…k-monitoring` (elastic#202860)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 2 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/monitoring-collection-plugin` |
`x-pack/platform/plugins/private/monitoring_collection` |
| `@kbn/monitoring-plugin` |
`x-pack/platform/plugins/private/monitoring` |

<details >
<summary>Updated relative paths</summary>

```
x-pack/platform/plugins/private/monitoring/dev_docs/how_to/testing.md:7
x-pack/platform/plugins/private/monitoring/dev_docs/how_to/testing.md:8
x-pack/platform/plugins/private/monitoring/jest.config.js:10
x-pack/platform/plugins/private/monitoring/tsconfig.json:2
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:100
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:103
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:106
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:109
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:115
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:121
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:127
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:130
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:133
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:136
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:139
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:142
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:145
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:19
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:2
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:22
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:25
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:28
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:31
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:34
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:37
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:64
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:67
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:70
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:73
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:76
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:79
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:82
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:85
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:88
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:91
x-pack/platform/plugins/private/monitoring/tsconfig.type_check.json:97
x-pack/platform/plugins/private/monitoring_collection/jest.config.js:10
x-pack/platform/plugins/private/monitoring_collection/tsconfig.json:2
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:16
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:19
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:2
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:22
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:25
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:28
x-pack/platform/plugins/private/monitoring_collection/tsconfig.type_check.json:31
```

</details>

---------

Co-authored-by: pgayvallet <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 47f675c)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/.i18nrc.json
#	x-pack/platform/plugins/private/monitoring/public/components/logs/__snapshots__/logs.test.js.snap
#	x-pack/platform/plugins/private/monitoring/public/components/logs/__snapshots__/logs.test.tsx.snap
#	x-pack/platform/plugins/private/monitoring/public/components/logs/__snapshots__/reason.test.js.snap
#	x-pack/platform/plugins/private/monitoring/public/components/logs/__snapshots__/reason.test.tsx.snap
#	x-pack/platform/plugins/private/monitoring/public/components/logs/index.js
#	x-pack/platform/plugins/private/monitoring/public/components/logs/index.tsx
#	x-pack/platform/plugins/private/monitoring/public/components/logs/logs.js
#	x-pack/platform/plugins/private/monitoring/public/components/logs/logs.test.js
#	x-pack/platform/plugins/private/monitoring/public/components/logs/logs.test.tsx
#	x-pack/platform/plugins/private/monitoring/public/components/logs/logs.tsx
#	x-pack/platform/plugins/private/monitoring/public/components/logs/reason.js
#	x-pack/platform/plugins/private/monitoring/public/components/logs/reason.test.js
#	x-pack/platform/plugins/private/monitoring/public/components/logs/reason.test.tsx
#	x-pack/platform/plugins/private/monitoring/public/components/logs/reason.tsx
#	x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.tsx.snap
#	x-pack/plugins/monitoring/public/components/logs/__snapshots__/reason.test.tsx.snap
#	x-pack/plugins/monitoring/public/components/logs/index.tsx
#	x-pack/plugins/monitoring/public/components/logs/logs.test.tsx
#	x-pack/plugins/monitoring/public/components/logs/logs.tsx
#	x-pack/plugins/monitoring/public/components/logs/reason.test.tsx
#	x-pack/plugins/monitoring/public/components/logs/reason.tsx
#	x-pack/plugins/telemetry_collection_xpack/schema/xpack_platform.json
#	x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 24, 2024

💔 Build Failed

Failed CI Steps

History

@pgayvallet pgayvallet merged commit 8642be7 into elastic:8.x Dec 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants